Skip to content

Add GitHub Copilot code review instructions#581

Merged
feliperodri merged 2 commits intomodel-checking:mainfrom
feliperodri:review-guidelines
Mar 31, 2026
Merged

Add GitHub Copilot code review instructions#581
feliperodri merged 2 commits intomodel-checking:mainfrom
feliperodri:review-guidelines

Conversation

@feliperodri
Copy link
Copy Markdown

Add .github/copilot-instructions.md to guide GitHub Copilot's automated code reviews for this repository. This will help us triage the coming wave of challenge solutions.

The instructions cover review guidelines for the four types of PRs we receive:

  • Challenge solutions — formal verification rigor (no vacuous proofs, justified assumptions, contracts matching safety docs), Rust std library code quality standards, and success criteria compliance.
  • New challenge proposals — template and tracking issue requirements.
  • New tool applications — CI workflow and book entry requirements.
  • Maintenance — ensuring existing proofs are not weakened.

Also includes a list of common red flags to watch for (e.g., over-constrained assumptions, missing cfg gates, unapproved tools).

Reference: Copilot code review custom instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri added the Maintenance Maintenance related issues for the challange label Mar 31, 2026
@feliperodri feliperodri requested a review from a team as a code owner March 31, 2026 19:56
@feliperodri feliperodri enabled auto-merge March 31, 2026 20:58
@feliperodri feliperodri added this pull request to the merge queue Mar 31, 2026
Merged via the queue into model-checking:main with commit 314fbd7 Mar 31, 2026
27 of 28 checks passed
@feliperodri feliperodri deleted the review-guidelines branch March 31, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Maintenance related issues for the challange

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants